Skip to content

[improve][test] Improve SubscriptionMessageDispatchThrottlingTest to reduce the execution time#18039

Merged
Technoboy- merged 1 commit intoapache:masterfrom
coderzc:slow/MessageDispatchThrottlingTest
Oct 17, 2022
Merged

[improve][test] Improve SubscriptionMessageDispatchThrottlingTest to reduce the execution time#18039
Technoboy- merged 1 commit intoapache:masterfrom
coderzc:slow/MessageDispatchThrottlingTest

Conversation

@coderzc
Copy link
Member

@coderzc coderzc commented Oct 13, 2022 •
edited
Loading

Fixed

Modifications

Only execution once setup/clean and clean tenants/namespaces/ config after the end of each test execution.

Execution time after improve test:

Tests run: 60, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 242.091 s - in org.apache.pulsar.client.api.SubscriptionMessageDispatchThrottlingTest

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

Matching PR in forked repository

PR in forked repository: coderzc#14

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 13, 2022
@coderzc coderzc force-pushed the slow/MessageDispatchThrottlingTest branch 2 times, most recently from f7d9d61 to 1f122f1 Compare October 13, 2022 12:32
@Technoboy- Technoboy- added this to the 2.12.0 milestone Oct 14, 2022
@Technoboy- Technoboy- closed this Oct 14, 2022
@Technoboy- Technoboy- reopened this Oct 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2022 •
edited
Loading

Codecov Report

Merging #18039 (1c7e5f7) into master (6c65ca0) will increase coverage by 15.73%.
The diff coverage is 55.55%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #18039       +/-   ##
=============================================
+ Coverage     34.91%   50.65%   +15.73%     
- Complexity     5707     7086     +1379     
=============================================
  Files           607      393      -214     
  Lines         53396    43422     -9974     
  Branches       5712     4462     -1250     
=============================================
+ Hits          18644    21994     +3350     
+ Misses        32119    18995    -13124     
+ Partials       2633     2433      -200
Flag Coverage Δ
unittests 50.65% <55.55%> (+15.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../service/SystemTopicBasedTopicPoliciesService.java 61.07% <0.00%> (+9.48%) ⬆️
...g/apache/pulsar/compaction/CompactedTopicImpl.java 69.28% <0.00%> (+58.57%) ⬆️
...broker/delayed/InMemoryDelayedDeliveryTracker.java 65.00% <75.00%> (+65.00%) ⬆️
...rg/apache/pulsar/broker/service/BrokerService.java 59.02% <100.00%> (+11.02%) ⬆️
...java/org/apache/pulsar/proxy/stats/TopicStats.java 58.82% <0.00%> (-41.18%) ⬇️
...ar/broker/loadbalance/impl/BundleSplitterTask.java 60.00% <0.00%> (-17.78%) ⬇️
...ersistentStickyKeyDispatcherMultipleConsumers.java 44.71% <0.00%> (-11.06%) ⬇️
...ervice/persistent/MessageRedeliveryController.java 56.09% <0.00%> (-4.88%) ⬇️
...e/pulsar/broker/service/EntryBatchIndexesAcks.java 89.28% <0.00%> (-3.58%) ⬇️
...pache/pulsar/proxy/server/ProxyServiceStarter.java 60.66% <0.00%> (-1.34%) ⬇️
... and 361 more

@coderzc coderzc force-pushed the slow/MessageDispatchThrottlingTest branch from 1f122f1 to 1c7e5f7 Compare October 14, 2022 02:45
@coderzc
Copy link
Member Author

coderzc commented Oct 14, 2022

/pulsarbot rerun-failure-checks

@Technoboy- Technoboy- merged commit 796afff into apache:master Oct 17, 2022
@hangc0276
Copy link
Contributor

hangc0276 commented Oct 20, 2022

This PR has two issues

  [INFO] Running org.apache.pulsar.broker.service.persistent.PersistentSubscriptionMessageDispatchStreamingDispatcherThrottlingTest
  Warning:  Tests run: 133, Failures: 0, Errors: 0, Skipped: 133, Time elapsed: 0.074 s - in org.apache.pulsar.broker.service.persistent.PersistentSubscriptionMessageDispatchStreamingDispatcherThrottlingTest
  [INFO] Running org.apache.pulsar.broker.service.persistent.SimpleProducerConsumerTestStreamingDispatcherTest
  Warning:  Tests run: 212, Failures: 0, Errors: 0, Skipped: 212, Time elapsed: 0.117 s - in org.apache.pulsar.broker.service.persistent.SimpleProducerConsumerTestStreamingDispatcherTest

We'd better not merge it before all the CI tests passed. @Technoboy- @codelipenghui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@mattisonchao mattisonchao mattisonchao approved these changes

Assignees

@coderzc coderzc

Labels

area/test doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@coderzc @codecov-commenter @hangc0276 @Technoboy- @mattisonchao